[Users] Couple of snags now I have Fedora 31

[Brian Morrison]

On Tue, 29 Oct 2019 16:18:25 +0100
Ricardo Mones <ricardo at mones.org> wrote:

> Hi Brian,
> 
> On Tue, Oct 29, 2019 at 02:24:00PM +0000, Brian Morrison wrote:
> > Hi devs
> > 
> > A couple of little problems with Claws building from git now that I
> > have Fedora 31.
> > 
> > First the check for libpython is not working, so I had to softlink
> > /usr/lib64/libpython3.7.so to /usr/lib64/libpython3.7m.so.1.0 because
> > detection on the existing /usr/lib64/libpython3.7m.so fails for the
> > python plugin.
> > 
> > More serious are the following errors:
> > 
> > Firstly one of the continue statements in
> > 
> > git/claws/tools/gitlog2changelog.py
> > 
> > is prefixed by a tab character instead of spaces to indent it, for some
> > reason this upsets the interpreter.  
> 
> Fixed in git.
> 
> > In addition I get this:
> > 
> > ...
> > touch config.h.in
> > Traceback (most recent call last):
> >   File "./tools/gitlog2changelog.py", line 43, in <module>
> >     if re.match('^commit', line) >= 0:
> > TypeError: '>=' not supported between instances of 're.Match' and 'int'
> > make[2]: *** [Makefile:1332: ChangeLog] Error 1
> > make[2]: Leaving directory '/home/bdm/git/claws'
> > make[1]: *** [Makefile:900: distdir] Error 2
> > make[1]: Leaving directory '/home/bdm/git/claws'
> > make: *** [Makefile:1000: dist] Error 2
> > 
> > Something in python has become more picky about syntax/semantics.
> > Naturally there are other similar statements that would fail if the
> > execution got that far.
> > 
> > Any thoughts?  
> 
> You need Python 2.x for that script, Python 3 returns a match object¹,
> not an integer. Until somebody migrates it to Python 3, I've also
> updated the interpreter line of the script to reflect this.
> 
> regards,
> 
> ¹ https://docs.python.org/3/library/re.html#re.match

OK, well that clears those errors, but I now get this:

touch config.h.in
  File "./tools/gitlog2changelog.py", line 72
    elif re.match('    git-svn-id:', line) >= 0:
       ^
SyntaxError: invalid syntax
make[2]: *** [Makefile:1332: ChangeLog] Error 1
make[2]: Leaving directory '/home/bdm/git/claws'
make[1]: *** [Makefile:900: distdir] Error 2
make[1]: Leaving directory '/home/bdm/git/claws'
make: *** [Makefile:1000: dist] Error 2

Fun isn't it!

-- 

Brian Morrison

                "I am not young enough to know everything"
                                                          Oscar Wilde