[Users] [Bug 3924] Fix configuration of sieve plugin on FreeBSD (segfaulted)

[noreply at thewildbeast.co.uk]

http://www.thewildbeast.co.uk/claws-mail/bugzilla/show_bug.cgi?id=3924

--- Comment #5 from Michael Gmelin <freebsd at grem.de> ---
(In reply to comment #4)
> (In reply to comment #3)
> > Thanks for applying the patch so quickly.
> > 
> > Please note that it might make sense to simply make the code for win/openbsd
> > and freebsd the default and get rid of the ifdefs. I don't think using "%ms"
> > buys that much and it might still break on mac os x, netbsd etc. in its
> > current state.
> 
> Well, it's very convenient to avoid dealing with fixed-length buffers in the
> application and let the underlying library do it better :-)
> 
> https://stackoverflow.com/questions/38685724/difference-between-ms-and-s-
> scanf
> 
> Haven't heard about others breaking, but maybe there's a better way to
> protect the %ms usage with feature flags.

It's certainly convenient when you work on just one platform that supports it
(and safer too). As claws is multi-platform, you end up with a lot more code to
maintain and test (and leaving some platforms vulnerable). Even with feature
flags you would end up with mupltiple code paths, so I'm not sure how it's
useful in this case. If anything, some sort of project-global wrapper could
make sense. Anyway, like I said, it works for me now :)

-- 
You are receiving this mail because:
You are the assignee for the bug.