[Users] [Bug 3817] Rework alertpanel focus handling

noreply at thewildbeast.co.uk noreply at thewildbeast.co.uk
Thu May 11 12:16:48 CEST 2017


http://www.thewildbeast.co.uk/claws-mail/bugzilla/show_bug.cgi?id=3817

--- Comment #4 from flo.xfce at gmx-topmail.de ---
Passing a struct will not really help. Look at the patch to get an idea of how
many call to alertpanel_* there are. Everytime we would have to fill a new
struct, this does not help readability or maintainability at all.
Of course gtk3 has support for freedesktop icon names, but it deprecated the
mapping between an icon and a label.
gtk_button_new_from_stock (which is used internally in alertpanel_create) just
needs the stock item and infers label and icon automatically, this is no longer
possible with non-deprecated api. gtk_button_new_from_icon_name and
gtk_button_set_label do this now.

-- 
You are receiving this mail because:
You are the assignee for the bug.



More information about the Users mailing list