[Users] Please revert "make Go to/[Next|Prev] sort order aware"

[Olivier Brunel]

On Mon, 27 Mar 2017 11:47:53 +0200
Andrej Kacian <andrej at kacian.sk> wrote:

> On Mon, 27 Mar 2017 11:05:15 +0200
> Olivier Brunel <jjk at jjacky.com> wrote:
> 
> > Besides, this also seem to imply an assumption that sort order is
> > date-based. What is I sort by size? color label? or whether
> > messages have attachments or not? Or does that refer to which
> > item/message is "last"? What if the list isn't sorted at all?  
> 
> I'm not going to touch rest of your e-mail, because it's just a bunch
> of opinions presented as facts, but this one is blatantly incorrect.
> The code in this case cares about whether the current sort order is
> ascending or descending, it doesn't care about which column is used
> for sorting.

So "blatantly incorrect" you say, but whilst the code there doesn't
*reference* the column used for sorting, what it *actually* does is make
sure the column is the only thing that matters.

To approach this another way, the commit I mentioned says, as do the
release notes, that the go to previous/next were "made sort order
aware", and that's just, this time, blatantly incorrect. :)

They were always sort order aware - in fact that's the reason I'm
complaining here, because that was broken. What this really did, is
made them *ignore* the sort *direction* (and always treat it as if
sorted ascendingly, hence why when descendingly, next will go up).

I don't believe that's expected behavior at all in general, and I'm not
even sure it makes much sense/use, except for people - as Dave Howorth
- who sort by date, maybe desc, yet always want those goto prev/next to
process messages ascendingly. (Hence my saying earlier it assumes the
list is sorted by date, because it feels that's the only use case
intended/useful.)

So I feel a sensible thing to do would be to make this option-based, an
option that correctly states it makes the go to prev/next actions ignore
the sort direction, since that is what it does (and that, IMHO, should
be disabled by default).

Cheers,