[Users] [PATCH] quicksearch: expand extended symbols on "Edit"

[Olivier Brunel]

On Sun, 11 Jun 2017 00:07:59 +0200
wwp <subscript at free.fr> wrote:

> Hello Olivier,
> 
> 
> On Sat, 10 Jun 2017 23:55:49 +0200 Olivier Brunel <jjk at jjacky.com>
> wrote:
> 
> > On Sat, 10 Jun 2017 23:23:51 +0200
> > wwp <subscript at free.fr> wrote:
> >   
> > > Hello Olivier,
> > > 
> > > 
> > > On Sat, 10 Jun 2017 23:09:02 +0200 Olivier Brunel <jjk at jjacky.com>
> > > wrote:
> > >   
> > > > Instead of silently ignoring the current string when it used
> > > > extended symbols, expand it into condition expressions to allow
> > > > editing it. ---
> > > > This could be a matter of personal preferences I guess, but as I
> > > > added a similar feature/button to vfolder, I did it that way
> > > > because from a user POV I find it more useful to have the
> > > > extended symbols expanded & editable, rather than an empty list
> > > > of conditions.
> > > > 
> > > > Besides, it much easier/quicker to hit "Clear" first it one
> > > > wants an empty list, than having to re-set manually whatever the
> > > > expression of extended symbols might have been.
> > > > 
> > > > So, here's a suggestion to do the same in quicksearch.    
> > > [snip]
> > > 
> > > Hah. That is nice (to me), I always wondered why qs-specific
> > > expressions were not edited when the edit button was clicked.
> > > 
> > > BTW, your patch seems to work fine here BUT I've found what looks
> > > like a bug:
> > > 
> > > mode: Extended
> > > value: unread   (it's a standard filtering condition expression)  
> > > -> click [Edit]    
> > > and no condition is set in the condition configuration dialog.
> > > 
> > > It seems related to your patch, 'cause it works well if not
> > > applied.  
> > 
> > Ah yes, nice catch. Attached should be a fixed version. (I'll have
> > to do the same in vfolder as well.)  
> 
> Thanks for your quick reaction. Why were you looking for ' ' in the
> string, BTW?

It comes from creating the MRU I think; I used the code from
quicksearch.c as basis, and there it looks for space to differentiate
"normal" search strings (no space) vs extended ones (w/ space)

That was some unneeded leftover from there.


> Regards,
>