[Users] [PATCH 4/8] osx: make sure that dialog windows are menu-less

[Igor Mammedov]

On Tue, 20 Jan 2015 22:39:07 +0100
Andrej Kacian <andrej at kacian.sk> wrote:

> On Tue, 20 Jan 2015 22:14:38 +0100
> Igor Mammedov <imammedo at redhat.com> wrote:
> 
> > However on OSX it's not so and if shortcut is a normal character
> > that user tries to type into input field of dialog window,
> > keystroke will be intercepted by menu and result in connected action.
> > 
> > To fix issue assign empty menu when creating toplevel windows so that
> > menu-less dialogs wouldn't have any menu/accelerators by default to
> > avoid issue.
> 
> Hi, I like the patches so far, except for a nitpick here. The described
> keystroke-snatching issue sounds like something that should be fixed
> once and for all in OSX version of GTK+, not by workarounds in
> individual applications. Or is there already a plan in motion to have
> this fixed , and the workarounds in your patches 4-8 are just temporary?
I know close to nothing about GTK, so I probably won't be abe to fix it there.
Hence, I've opened a bug about it
 https://bugzilla.gnome.org/show_bug.cgi?id=743282

> 
> Also, I would prefer if all of these claws_mail_osx_*() functions were
> contained within "#ifdef __APPLE__" blocks. Or is there a reason to
> call them unconditionally?
claws_mail_osx_*() functions are ifdeffed in src/cm_osx.h header to empty
inline functions if build without MAC_INTEGRATION define and they are
optimized out by compiler so there aren't any calls here.

As result it's a bit cleaner code /only one ifdef/.

However it's upto preference of maintainer, if you prefer ifdefs around
every call I can do it and respin amended series.

> 
> Thanks for your effort so far, Igor.
> 
> (Cc-ing you, since I have no idea if you are subscribed to users ML.)
It appears that I am subscribed.

> 
> Regards,