[Users] [PATCH 4/8] osx: make sure that dialog windows are menu-less

Andrej Kacian andrej at kacian.sk
Tue Jan 20 22:39:07 CET 2015


On Tue, 20 Jan 2015 22:14:38 +0100
Igor Mammedov <imammedo at redhat.com> wrote:

> However on OSX it's not so and if shortcut is a normal character
> that user tries to type into input field of dialog window,
> keystroke will be intercepted by menu and result in connected action.
> 
> To fix issue assign empty menu when creating toplevel windows so that
> menu-less dialogs wouldn't have any menu/accelerators by default to
> avoid issue.

Hi, I like the patches so far, except for a nitpick here. The described
keystroke-snatching issue sounds like something that should be fixed
once and for all in OSX version of GTK+, not by workarounds in
individual applications. Or is there already a plan in motion to have
this fixed , and the workarounds in your patches 4-8 are just temporary?

Also, I would prefer if all of these claws_mail_osx_*() functions were
contained within "#ifdef __APPLE__" blocks. Or is there a reason to
call them unconditionally?

Thanks for your effort so far, Igor.

(Cc-ing you, since I have no idea if you are subscribed to users ML.)

Regards,
-- 
Andrej



More information about the Users mailing list