[Users] Fix Maildir ++ plugin maildir-0.24.5 patch

[Ricardo Mones]

  Hi Brian,

On Fri, May 10, 2013 at 01:55:27AM +0100, root wrote:
> The attached patch file updates ClawsPlugins/maildir-0.24.4 from the
> current, non working Maildir ++ plugin to (new 0.24.5) which works with
> current gtk builds and, when loaded as a Claws plugin, enables the use
> of Mdir mailboxes with which Claws can use, create and move messages.
> 
> This was part of my exit from Kmail 2.x.
> 
> I am not offering to maintain this but I will post any bug fixes to the
> list.

  So, you're going to maintain it, but don't want to be "the maintainer".
  Thanks, I guess that's better than nothing :)

> I work in git so this is:
> 
> cpommit: cac297897935723ec3a474ba57825a4ed90e3151
> 
> patch in line and as gziped attachment: SHA1
> 
> SHA1: 074fc5786545c1b81be2db1a7eae4e8d2c879532

  I guess this is some git you've created, since maildir sources are _not_
in our git.
  Is it available online?
 
> ====
> 
> diff --git a/config.h b/config.h
> diff --git a/pluginconfig.h b/pluginconfig.h

  These are generated files, shouldn't be in the patch.

> +// Plugin licence crap
> +/*
> +
> +const gchar const *my_plugin_licence_tokens[] = {
> + "LGPL2.1+", "LGPLv2.1+", "LGPL2.1", "LGPLv2.1",
> + "LGPL3+", "LGPLv3+", "LGPL3", "LGPLv3",
> + "GPL3+", "GPLv3+", "GPL3", "GPLv3",
> + "GPL2+", "GPLv2+",
> + "Apache2.0", "Apache 2.0", "Apache v2.0",
> + "2-clause BSD", "Simplified BSD", "FreeBSD",
> + "3-clause BSD", "New BSD", "Modified BSD",
> + NULL
> +};

  What is this for? Shouldn't be here.
  And of course such wording in comments is not appreciated.

> +const gchar* plugin_version(void) {
> +	return "123.0";
> +}
> +

  Really?

> +const gchar* plugin_desc(void) {
> +	return ("This plugin adds archiving features to Claws Mail.\n"
> +			"\n"
> +			"It enables you to use maildir filders"
> +			"Default options can be set
> in /Configuration/Preferences/Plugins"
> +			);
> +}

  Don't think so... and please use English for descriptions ;)

> @@ -128,6 +174,7 @@ FolderClass *maildir_get_class()
>  		maildir_class.copy_msg = maildir_copy_msg;
>  		maildir_class.remove_msg = maildir_remove_msg;
>  		maildir_class.change_flags = maildir_change_flags;
> +		// XXXX
>  		maildir_class.get_flags = maildir_get_flags;
>  	}

  XXXX?

> -		g_relation_insert(msgflags, msginfo,
> GINT_TO_POINTER(flags));
> +		// XXXX but no new API
> +		// g_relation screwed up! OMB relation never
> created ...
> +		// commenting out the next line fixes the segfault but
> needs more work. ??? no Falags XXXX
> +		// g_relation_insert(msgflags, msginfo,
> GINT_TO_POINTER(flags));

  I think a better technically-oriented expletive-free description of what's
happening here is needed. Anyway I've tried to apply against current maildir
in CVS:

patching file config.h
patching file pluginconfig.h
patching file src/maildir.c
Hunk #3 FAILED at 288.
Hunk #4 succeeded at 360 with fuzz 2 (offset 8 lines).
Hunk #5 FAILED at 1348.
2 out of 5 hunks FAILED -- saving rejects to file src/maildir.c.rej
patching file src/maildir_gtk.c
Hunk #1 FAILED at 38.
Hunk #2 FAILED at 146.
Hunk #3 FAILED at 172.
Hunk #4 FAILED at 193.
Hunk #5 FAILED at 205.
Hunk #6 FAILED at 245.
Hunk #7 FAILED at 276.
Hunk #8 FAILED at 306.
Hunk #9 FAILED at 329.
9 out of 9 hunks FAILED -- saving rejects to file src/maildir_gtk.c.rej
patching file src/plugin.c
Reversed (or previously applied) patch detected!  Assume -R? [n] n
Apply anyway? [n] n
Skipping patch.
2 out of 2 hunks ignored -- saving rejects to file src/plugin.c.rej

  So, please, better send something against current git.

  regards,
-- 
  Ricardo Mones 
  ~
  Never send a human to do a machine's job.               Agent Smith
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.claws-mail.org/pipermail/users/attachments/20130510/cda703a0/attachment.sig>