[Users] [Bug 3035] Enhance diff coloring to git patches

noreply at thewildbeast.co.uk noreply at thewildbeast.co.uk
Thu Dec 12 18:52:51 CET 2013


--- Comment #2 from Andrej Kacian <andrej at kacian.sk> ---
This is something we discussed when the diff coloring for attachments was
added. The "gittiness" detection in your patch is quite naive, and will likely
yield many false positives (diff coloring used when it shouldn't be). All
that's needed is someone mentioning string "git --diff" in their mail, without
it being an actual git-generated mail with diff output.

If anything, maybe check for presence of X-Git-... message headers, or
something else that can reliably tell we're dealing with mail that has to be
diff-colored. And I'm not sure whether it is a good idea to go down this path.
Any more opinions?

You are receiving this mail because:
You are the assignee for the bug.

More information about the Users mailing list