[Users] [Bug 2828] Use MD5 digest for socket name

ratinox at gweep.net ratinox at gweep.net
Thu Nov 29 01:47:39 CET 2012


On Thu, 29 Nov 2012 01:08:38 +0100
Holger Berndt <berndth at gmx.de> wrote:

> But that's actually a feature, isn't it? [...]

Precisely. The purpose of a lock is to guarantee exclusive access to a
resource. If starting a second, concurrent instance of Claws Mail using
the same configuration directory fails then my patch is working
correctly. You need to completely shut down the first instance of CM
before starting the second with a different UID.

> Anyways, the patch misses the "normalizing the config directory" part
> that I was talking about - meaning to resolve symlinks and identities
> like /foo/bar == /foo/bar/../bar or /home/./foo == /home/foo, to make
> it slightly less easy for the user to shoot himself in the foot.

If canonicalization is necessary then I'd rather leave it to someone who
can handle the error and overflow cases. I'd make a mess of it if I
tried it myself.

-- 
\m/ (--) \m/



More information about the Users mailing list