[Users] [Bug 4130] New: Please reconsider merging the patch syntax highlight

noreply at thewildbeast.co.uk noreply at thewildbeast.co.uk
Sat Dec 1 22:03:07 CET 2018


https://www.thewildbeast.co.uk/claws-mail/bugzilla/show_bug.cgi?id=4130

            Bug ID: 4130
           Summary: Please reconsider merging the patch syntax highlight
    Classification: Unclassified
           Product: Claws Mail
           Version: other
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P3
         Component: UI/Message View
          Assignee: users at lists.claws-mail.org
          Reporter: kubakici at wp.pl

Three years back I submitted a patch to highlight git --diff syntax in-line
inside email bodies.  It was rejected due to fear of false positives.

I've used it since and never had a false positive.  I have also found that
other people have very similar patches on GitHub, which makes me thinks its a
popular feature.

I have had a quite a few of my coworkers start using my fork of Claws just to
get the patch coloring, and subsequently go back to Thunderbird because of the
extra hassle of having to compile from source and rebase.  I think it would be
a really good thing for the project if the feature got merged.

Patches are available here:
https://github.com/kuba-moo/claws-mail/commit/ed5adc67276e7ee0e50c031daccfddcc92488e30
https://github.com/kuba-moo/claws-mail/commit/36300a476c2dc401dd78e3396a6b19848041c08f

Please let me know if I can improve them somehow.

-- 
You are receiving this mail because:
You are the assignee for the bug.



More information about the Users mailing list