[Users] Conditional requests for RSSyl

[wwp]

Hello Ivan,


On Sun, 16 Mar 2025 17:48:57 +0300 Ivan Krylov via Users <users at lists.claws-mail.org> wrote:

[snip]
> Currently, RSSyl always makes unconditional requests for feed content.
> While feed_update() in src/plugins/rssyl/libfeed/feed.c does accept a
> last_update argument:
> 
> >> if( last_update != -1 ) {
> >> 	curl_easy_setopt(eh, CURLOPT_TIMECONDITION,
> >> 	                 CURL_TIMECOND_IFMODSINCE);
> >> 	curl_easy_setopt(eh, CURLOPT_TIMEVALUE,
> >>	                 (long)last_update);
> >> }  
> 
> ...the function is only called with -1 as the time condition, from
> rssyl_fetch_feed() -> rssyl_fetch_feed_thr() in
> src/plugins/rssyl/rssyl_update_feed.c:
> 
> >> ctx->response_code = feed_update(ctx->feed, -1);  
> 
> I know two (relatively small) independent feed operators who banned
> users of RSSyl as a result: once by User-Agent and once by IP address.

Here's a draft patch to make the RSSyl User Agent configurable in Claws Mail:
the default one is "ClawsMailRSSyl/$VERSION ($URL)" (kind of standard),
you can override it globally for all feeds in Preferences/Plugins/RSSyl,
and even on a per-feed basis (in every feed's properties):
  https://www.mollux.org/projects/contrib/claws-mail/patches/rssyl-custom-user-agent-step1-rev2.diff


Regards,

-- 
wwp
https://useplaintext.email/