[Users] [Bug 4735] New: adjust logic in image_viewer_load_image

noreply at thewildbeast.co.uk noreply at thewildbeast.co.uk
Thu Jan 11 12:46:52 UTC 2024


https://www.thewildbeast.co.uk/claws-mail/bugzilla/show_bug.cgi?id=4735

            Bug ID: 4735
           Summary: adjust logic in image_viewer_load_image
           Product: Claws Mail (GTK 2)
           Version: GIT
          Hardware: PC
                OS: All
            Status: NEW
          Severity: normal
          Priority: P3
         Component: Other
          Assignee: users at lists.claws-mail.org
          Reporter: olaf at aepfle.de

Created attachment 2399
  -->
https://www.thewildbeast.co.uk/claws-mail/bugzilla/attachment.cgi?id=2399&action=edit
gtk2-adjust-logic-in-image_viewer_load_image.patch

The function gdk_pixbuf_animation_new_from_stream may return NULL.
Take the branch only if animation is valid.

  image_viewer.c: In function 'image_viewer_load_image':
  image_viewer.c:105:16: warning: suggest parentheses around '&&' within '||'
[-Wparentheses]
    if (animation && gdk_pixbuf_animation_is_static_image(animation)

Fixes commit 05f600e5826ab4fd43e345b87bf1029c1fef48f7
Fixes commit e121fc4767e57fd6018997b75d636264049c9ce8
Fixes commit d006355369916eefff3d964d4606e183339418aa

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the Users mailing list