[Users] glib regex issue is stopping OAuth2 token update

[David Fletcher]

Michael Rasmussen <mir at miras.org> wrote:
>> Here is the last part of the string from my test program that has the
>> actual google server response data from the claws-mail internal
>> buffer:
>>
>>  \n  \"expires_in\": 3599,\n  \"scope\":
>> \"https://mail.google.com/\",\n  \"token_type\":
>> \"Bearer\"\n}\r\np\247yVUU" ;
>>
>> Should there be anything after }\r\n    ?
>>
>I don't have a google account so I cannot give any comments on google
>but you are right in assuming that what it shown after "}\r\n" is
>garbage but why there is garbage could be caused by numerous problems:
>1) Miscalculated body length in http header
>2) Some kind of buffer overflod in the socket library
>3) A message construction failure on the server side
>4) Something completely different
>
>Since Microsoft mail servers has the same behaviour I think we can rule
>out 3) but since the fix handles all possible error scenarios
>gracefully I would not waste much more time on this since it is
>impossible to replicate the error state (I have had an instance of
>claws running for a couple of hours logging debug output). I will
>continue doing so for the rest of the day but if a see no wrong
>behaviour and no claws error I will leave it as is.
>

I'd not experienced this issue (I'm usually connecting to Gmail). I've
just updated to the current git version with the new G_REGEX_RAW entry
so if I notice anything with the new version I'll reply on here.

Great that this has been fixed before it was happening here too!

David.