[Users] [Bug 4354] New: clawss-mail crashes in addr_comparison_func

[noreply at thewildbeast.co.uk]

https://www.thewildbeast.co.uk/claws-mail/bugzilla/show_bug.cgi?id=4354

            Bug ID: 4354
           Summary: clawss-mail crashes in addr_comparison_func
           Product: Claws Mail
           Version: GIT
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P3
         Component: UI
          Assignee: users at lists.claws-mail.org
          Reporter: jens.gustedt at inria.fr

Created attachment 2064
  -->
https://www.thewildbeast.co.uk/claws-mail/bugzilla/attachment.cgi?id=2064&action=edit
patch to mitigate the crash

For some folders claws-mail crashes in this function because some of the
pointed-to names are null. This happens to me with the version that is
distributed version in Ubuntu LTS 20.4 as well as with a freshly compiled
version from git.


This function is not really complicated so adding

+        else if (!a_ref || !b_ref)
+               return 1;
+        else if (!a_ref->name || !b_ref->name)
+               return 1;

helped. (I am attaching a patch, just in case.)

Knowing if there is a general assumption here, that these can't be null or not,
is beyond my expertise as a simple user, but I would think that adding such a
check is a good idea, anyhow.

Thanks
Jens

-- 
You are receiving this mail because:
You are the assignee for the bug.