[Users] [Bug 4351] Priority is SMTP authentication

[noreply at thewildbeast.co.uk]

https://www.thewildbeast.co.uk/claws-mail/bugzilla/show_bug.cgi?id=4351

--- Comment #3 from Hanno Boeck <hanno at hboeck.de> ---
I think the original bug description is not correct. The code is in the
function smtp_auth here:
https://git.claws-mail.org/?p=claws.git;a=blob;f=src/common/smtp.c;h=2460f7e0455e3d1fbc5715bc3669cc3ca99399b2;hb=HEAD#l156

This looks like it is forcing a method that is configured if there is one, and
if not then it is using CRAM-MD5, LOGIN, PLAIN in that order.

I agree however the order should be changed. PLAIN spares a roundtrip, thus it
is faster and more likely to work with a weak internet connection. I am
attaching a patch that switches PLAIN and LOGIN, which means if both are
available PLAIN will be used.

One can argue around the order of CRAM-MD5 vs. the others, but CRAM-MD5 is not
widely supported anyway, so I would consider that of minor importance. One may
also consider just completely removing LOGIN, as it's never been standardized,
it only exists as a 17 year old draft and IANA considers it as obsolete [1].

[1] https://www.iana.org/assignments/sasl-mechanisms/sasl-mechanisms.xhtml

-- 
You are receiving this mail because:
You are the assignee for the bug.