[Users] [Bug 3889] address and quoted message inconsistent in reply

[noreply at thewildbeast.co.uk]

https://www.thewildbeast.co.uk/claws-mail/bugzilla/show_bug.cgi?id=3889

Colin Leroy <colin at colino.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #1913|0                           |1
        is obsolete|                            |
   Attachment #1924|0                           |1
        is obsolete|                            |

--- Comment #23 from Colin Leroy <colin at colino.net> ---
Created attachment 1925
  -->
https://www.thewildbeast.co.uk/claws-mail/bugzilla/attachment.cgi?id=1925&action=edit
Another better patch

Following more IRC chat, I think we can say that:

WE HAVE:

Message A is displayed, message A is selected
    Mainwindow replies => To message A
    Toolbar replies => To message A
    SummaryPopup on message A replies => To message A
    SummaryPopup on other message replies => To message A (IT SHOULDN'T)

Message A is displayed, messages A B C are selected
    Mainwindow replies => To A, B, C
    Toolbar replies => To A, B, C
    SummaryPopup on message A, B or C replies => To A, B, C
    SummaryPopup on other message (D) replies => To message A (IT SHOULDN'T)

Message A is displayed, but one other only, B, is selected
    Mainwindow replies => to message A with some corner-case bug in address
selection (https://www.colino.net/tmp/reply.ogv)
    Toolbar replies => to message A with some corner-case bug in address
selection (https://www.colino.net/tmp/reply.ogv)
    SummaryPopup on message A replies => to message A with some corner-case bug
in address selection (https://www.colino.net/tmp/reply.ogv)
    SummaryPopup on message B replies => to message A, with message B To
address (IT SHOULDN'T)
    SummaryPopup on other message (D) replies => to message A, with message D
To address (IT SHOULDN'T)

Message A is displayed, but others only (B C D) are selected
    Mainwindow replies => to selected messages B C D
    Toolbar replies => to selected messages B C D
    SummaryPopup on one of the selected messages replies => B C D
    SummaryPopup on another message (E) replies => to message A, with message E
To address (IT SHOULDN'T)

WE WANT:

Message A is displayed, message A is selected
    Mainwindow replies => To message A
    Toolbar replies => To message A
    SummaryPopup on message A replies => To message A
    SummaryPopup on other message B (selects B) replies => To message B

Message A is displayed, messages A B C are selected
    Mainwindow replies => To A, B, C
    Toolbar replies => To A, B, C
    SummaryPopup on message A, B or C replies => To A, B, C
    SummaryPopup on other message (D) (selects D) replies => To message D

Message A is displayed, but one other only, B, is selected
    Mainwindow replies => to message A
    Toolbar replies => to message A
    SummaryPopup on message A (selects A) replies => to message A
    SummaryPopup on message B replies => to message B
    SummaryPopup on other message (D) (selects D) replies => to message D

Message A is displayed, but others only (B C D) are selected
    Mainwindow replies => to message A
    Toolbar replies => to message A
    SummaryPopup on one of the selected messages replies => B C D
    SummaryPopup on another message (E) (selects E) replies => to message E

This doesn't describe precisely the "only quote selected part of the mail"
feature,
nor the "reply to attached message/rfc822 when it is the currently selected
part" feature,
which don't change and only applies when we reply to displayed message A and
only message A is selected.

The attached patch implements that "WE WANT" part.

-- 
You are receiving this mail because:
You are the assignee for the bug.