[Users] [Bug 4104] SMTP doesn't work over VPN

[Andrej Kacian]

On Wed, 28 Nov 2018 17:17:53 +0100
Michal Suchánek wrote:

> On Wed, 28 Nov 2018 14:57:35 +0100
> "Paul Rolland (ポール・ロラン)" <rol at witbe.net> wrote:
> 
> > Hello,
> > 
> > On Wed, 28 Nov 2018 14:27:07 +0100
> > Michal Suchánek <msuchanek at suse.de> wrote:
> >   
> > > No. It is reported in the terminal as 
> > > 
> > > fork: Cannot allocate memory
> > > 
> > > but it is not reported in the networking log window at all. Without
> > > logging the terminal messages or tracing claws you have no idea what
> > > happened.    
> > 
> > Could it be conn_data->lookup_data not being freed ?
> > 
> > Not sure though, I'm not familiar with common/socket.c...
> >   
> 
> It looks like this code:
> 
> #ifndef G_OS_WIN32
>         if ((lookup_data->child_pid = fork()) < 0) {
>                 perror("fork");
>                 func(NULL, data);
>                 g_free (lookup_data->hostname);
>                 g_free (lookup_data);
>                 return NULL;
>         }
> 
> It produces the observed message and never propagates a meaningful
> error. There you go.

Yes, perhas the error could be made a bit more apparent to the user. I
think that this (fork() failing) is one of those situations which nobody
expects to happen, so the author of the code just threw the perror() in
there to have that "fork: Cannot allocate memory" line shown on stderr,
and moved on. :)

Regards,
-- 
Andrej
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://lists.claws-mail.org/pipermail/users/attachments/20181128/69e8145a/attachment.sig>