[Users] [Bug 3822] AttRemover deletes message and fails to create new one when disk is full

[noreply at thewildbeast.co.uk]

http://www.thewildbeast.co.uk/claws-mail/bugzilla/show_bug.cgi?id=3822

Ricardo Mones <mones at users.sourceforge.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |major

--- Comment #1 from Ricardo Mones <mones at users.sourceforge.net> ---
(In reply to comment #0)
> The other day, my server disk space was full. I tried to gain space using
> AttRemover and realized that the messages were simply deleted.
> 
> I guess the plugin deletes the old message, then tries to create a new one
> without the attachments, but if the creation fails, everything is lost.

That's correct, see
http://git.claws-mail.org/?p=claws.git;a=blob;f=src/plugins/att_remover/att_remover.c;h=1092c15ef650c18b226bdacee559de011f1583d3;hb=HEAD#l109

> Perhaps the new message should be created first and the whole process
> aborted in case of creation failure.

Yep, but checking for creation failure is also missing in current code.

And this is not just a normal bug, since it causes data loss.

-- 
You are receiving this mail because:
You are the assignee for the bug.