[Users] Virtual folders

[Olivier Brunel]

Hi,

First of all, let me say that I've been using claws for some time
now, and I like it a lot. It's a great software, and having looked
around in the source code lately, I've also liked it from the inside;
Congratulations everyone, and thanks for all the great work you do on
this project.

As I said, I've looked in the source code, because lately I had been
thinking (again) about some things, basically boiling down to either
having a way to trigger custom/saved searches, or have virtual folders
that would be search results.

And I've ended up going with the later. I've seen some previous work in
that regard, notably on the bug tracker[1] as well as a branch vfolder
in the official git repo. However, neither of those "worked" for me so
I've decided to start from scratch, using a plugin approach as well.
(And, to be fair, I kept the name "vfolder" for it, because, well, it
fits very well. :) Hopefully that's not an issue.)

So after looking around the code and working on this, I find myself
having a couple questions :

* procmsg_msginfo_copy() doesn't copy tags, I originally assumed this
  was a bug and was gonna see to send a patch, but then I wondered: is
  this actually normal/expected behavior, or indeed a bug?

* There are no callbacks for sensitivity of e.g. FolderViewPopup or
  toolbar buttons (for plugins), or did I miss something?

* Again in the intended or a bug departement, I noticed that
  mh_remove_msg() doesn't check for MSG_IS_MOVE_DONE; But I'm not sure
  this is a bug, as in I assume that's for the same reason there's an
  implementation instead of making an MsgInfoList and calling
  mh_remove_msgs() on it: to work with the msgnum only w/out actually
  getting the MsgInfo. So this is on purpose/not to be fixed?

* I also noticed a couple minor things, for which I'll send patches.

* Lastly, but this falls under wishes I guess, I feel the toolbar
  options are a bit limited. For one, that for plugin actions one
  cannot set the text of the button; But also the number of icons
  available isn't great, and (unless I'm missing something) there's no
  way to use custom icons (e.g. select an external file, like one of
  the many pngs found in /usr/share/icons)?

And back on virtual folders, I'll also send the patch of course. I've
been using it for a little while and it seems to work fine, at least
over here. :)

I should mention that I don't have hundreds of thousands of mails, and
also use pretty much only MH mailboxes, so I'm not sure what it'll be
like on (very) large (IMAP) mailboxes, hopefully not awful.

I'm not sure what's the rule when it comes to merging new plugins, but
as that was easiest (for me) the patch simply adds it to the
src/plugins folder and updates configure/Makefile accordingly.

Cheers,


[1]
http://www.thewildbeast.co.uk/claws-mail/bugzilla/show_bug.cgi?id=2250