[Users] [Bug 3754] New: interactive auth dialogs pops endlessly

[noreply at thewildbeast.co.uk]

http://www.thewildbeast.co.uk/claws-mail/bugzilla/show_bug.cgi?id=3754

            Bug ID: 3754
           Summary: interactive auth dialogs pops endlessly
    Classification: Unclassified
           Product: Claws Mail
           Version: 3.14.1
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P3
         Component: Plugins/GData
          Assignee: users at lists.claws-mail.org
          Reporter: viacheslavg at gmail.com

I would identify two different (but related) issues here:

1. Interactive auth dialog can pop endlessly if user doesn't react on them.
i.e. when first dialog opens and user doesn't not provide auth token and
doesn't cancel/close it in time, then in some time (polling interval) second
dialog pops, and so on.

2. Interactive auth dialog initiated after any network error which can occur
when trying to refresh auth token.
Consider the case:
1) I got auth token from google
2) provided it to GData plugin. Now it is able to work fine.
3) in ~1 hour I faced with network issue. -- at this point GData tries to
refresh token and it is not able to do this due to network issue.
As result I again got interactive auth dialog (however my token is valid).
I think this is really annoying for user and asks for actually unnecessary
actions (there is really no reason for token regeneration).

I would propose to initiate auth dialog only in case when GData explicitly got
FORBIDDEN response from google, in other cases (usually just network issues)
ignore the error and retry token refresh again until succeeded.  

I'm attaching patch which solves these two issues for me. I'm not sure that it
is done in a good way, but it could be as a starting point.

-- 
You are receiving this mail because:
You are the assignee for the bug.