[Users] [Bug 3559] New: Opening preferences window causes out of bounds read

[noreply at thewildbeast.co.uk]

http://www.thewildbeast.co.uk/claws-mail/bugzilla/show_bug.cgi?id=3559

            Bug ID: 3559
           Summary: Opening preferences window causes out of bounds read
    Classification: Unclassified
           Product: Claws Mail
           Version: other
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P3
         Component: UI
          Assignee: users at lists.claws-mail.org
          Reporter: hanno at hboeck.de

Created attachment 1594
  -->
http://www.thewildbeast.co.uk/claws-mail/bugzilla/attachment.cgi?id=1594&action=edit
Patch to fix out of bounds

I was testing claws-mail compiled with the compiler feature address sanitizer
(-fsanitize=address in CFLAGS). This uncovered an out of bounds read when
trying to open the preferences window.

The code in question is here in the file src/gtk/prefswindow.c (line 323):
            if (find_name.found && page->path[i] != page->path[i-1]) {

The problem is that this is in a loop over i starting at 0. Therefore in the
first iteration it will try to access page->path[-1] and that is invalid.

The attached patch should fix it. Also attaching the full address sanitizer
stack trace.

-- 
You are receiving this mail because:
You are the assignee for the bug.