[Users] Redundant code?
Pierre Fortin
pf at pfortin.com
Sun Jan 25 17:20:36 CET 2015
Hi devs,
While responding to the "Error while sending..." thread, I browsed
the code and noticed something strange... Starting at compose.c:5193, I
see the below logic. [Not being critical; just pointing out what appears
to be redundant code.]
if (!discard_window) {
if (val != 0) {
[do code block]
}
}
if (val != 0) {
if (!discard_window) {
[do identical code block]
}
} else {
which can be summarized as:
if !dw && val:
code block
if val && !dw:
code block (identical copy)
else
# !val
I code mostly in Python, so I may be missing a C subtlety... :)
Thanks for your great efforts and HTH,
Pierre
More information about the Users
mailing list