[Users] [Bug 3325] Password conversion from plaintext to encrypted does not handle ! as first char of plaintext password

[noreply at thewildbeast.co.uk]

http://www.thewildbeast.co.uk/claws-mail/bugzilla/show_bug.cgi?id=3325

--- Comment #4 from Marvin <marvint.roebuck at inbox.lv> ---
Ok nothing to do with signedness.  That's what -Wno-pointer-sign is for.

But I wonder if anyone seeing this bug report knew right away what the problem
was/is.

I looked at .claws-mail/accountrc and notice that each encrypted password
begins with a !

Like so:
password=!abdCeF10293=
smtp_password=!etcetcetc=
in_ssl_client_cert_pass=!fubarfoobarorbarfoo=
out_ssl_client_cert_pass=!yesnoormaybeyes=

Or like this when no password has been set:

password=!


Why this has to be I can guess at but maybe someone knows exactly why.

My guess:
someone decided to use ! as a demarcation for the beginning of a
base64 encoded encrypted password string.

And somewhere, while encrypting, the ! is removed from unencrypted password
strings.

-- 
You are receiving this mail because:
You are the assignee for the bug.