[Users] [Bug 3321] selected message doesn't deselected when moving focus using up/down on keyboard

[noreply at thewildbeast.co.uk]

http://www.thewildbeast.co.uk/claws-mail/bugzilla/show_bug.cgi?id=3321

--- Comment #3 from Ricardo Mones <mones at users.sourceforge.net> ---
(In reply to comment #2)
> Reverting Mones commit
> 
> * 8090f02 - Remove unreachable code (4 weeks ago) <Ricardo Mones>
> 
> seems to fix it.

I'm curious about this. What changes the value of clist->selection_mode between
the "switch (clist->selection_mode)"¹/"case GTK_SELECTION_BROWSE"² and the
removed "if (clist->selection_mode == GTK_SELECTION_BROWSE)"³ ?

Because there's just a move_focus_row call which doesn't alter selection_mode
AFAICS (function seems to do what it says.

Anyway, if reverting it fixes the issue, go ahead. It's just I don't like
dealing with code which does magic ;)

¹
http://git.claws-mail.org/?p=claws.git;a=blob;f=src/gtk/gtkcmclist.c;h=7980b8a2#l7027
²
http://git.claws-mail.org/?p=claws.git;a=blob;f=src/gtk/gtkcmclist.c;h=7980b8a2#l7032
³ http://git.claws-mail.org/?p=claws.git;a=commitdiff;h=8090f02e

-- 
You are receiving this mail because:
You are the assignee for the bug.