[Users] [Bug 3215] [PATCH] Make wildcard address matching/autocomplete a bit smarter by sorting results in a more human way.

noreply at thewildbeast.co.uk noreply at thewildbeast.co.uk
Tue Jun 17 22:23:37 CEST 2014


http://www.thewildbeast.co.uk/claws-mail/bugzilla/show_bug.cgi?id=3215

Michael Gmelin <freebsd at grem.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |---

--- Comment #7 from Michael Gmelin <freebsd at grem.de> ---
Hi Colin,

The second extra check is important, but it seems to break the logic though by
using the wrong operator (didn't test it yet):

      if (strlen(match) < strlen(g_completion_prefix)
       && *(match + strlen(g_completion_prefix)) == '@')
        a_weight--;

I think this should be:

if (strlen(match) > strlen(g_completion_prefix) ..

since strlen(match) is always >= strlen(g_completion_prefix) and never <
strlen(g_completion_prefix).

e.g. search for mg in mg at example.org
=> strlen(match) == 15
=> strlen(g_completion_prefix) == 2

-- 
You are receiving this mail because:
You are the assignee for the bug.



More information about the Users mailing list