[Users] [Bug 3085] folder_item_scan_full() does stupid things with ignored thread marks

noreply at thewildbeast.co.uk noreply at thewildbeast.co.uk
Fri Feb 7 19:19:59 CET 2014


http://www.thewildbeast.co.uk/claws-mail/bugzilla/show_bug.cgi?id=3085

--- Comment #1 from Jason <aidenn0 at geocities.com> ---
I spoke with paul on IRC about this.

It is intentional that children need to have some sort of prefix in the subject
indicating a reply.

However, it is bizzare how folder_item_scan_full tries to propagate ignored
thread marks (but not e.g. watched thread marks) and does so only by subject
(so not by in-reply-to). And will do so both up and down the thread tree (so if
you ignored a sub-thread, congratulations, the whole thread is now ignored --
but only e-mails from people on the thread didn't use in-reply-to.

The correct fix is to rip out that messed up logic, and if it is desired to
propagate these marks in scan_full then use the logic for building up threads
correctly that is from the threaded view in the summary, then walk the tree and
propagte to children.

I can submit a patch that does the "Right Thing" or just rip out the broken
ignore-thread code, depending on whether or not people think that unmarked
children of {watched|ignored} threads should be marked likewise

-- 
You are receiving this mail because:
You are the assignee for the bug.



More information about the Users mailing list