[Users] [Bug 3348] Contact pictures not deleted when contact is deleted

[noreply at thewildbeast.co.uk]

http://www.thewildbeast.co.uk/claws-mail/bugzilla/show_bug.cgi?id=3348

--- Comment #8 from Charles Lehner <cel at celehner.com> ---
(In reply to comment #6)
> Anyway I disagree with the idea of returning a constructed path. I'm more
> inclined to build the path on the caller side and left the addrbook API
> untouched.
> 
> If later more callers appear it can be considered if the API should be
> modified or not.

What is the use of the addrbook API returning the picture other than as a
constructed path?

The callers of addritem_person_get_picture are using the result as a filename,
and so their operations are failing silently (except when the picture is from
an LDAP query, it looks like). See addressbook_del_clicked,
addrduplicates_delete_item_person, and addrindex_get_picture_file (which is
used in headerview.c and textview.c).

Caller-side operations which succeed are not using
addritem_person_get_picture(person), but are using person->picture and then
constructing the filename, so the proposed patch does not affect them.

-- 
You are receiving this mail because:
You are the assignee for the bug.