[Users] [Bug 3148] New: Logic error in claws_get_socket_name()

[noreply at thewildbeast.co.uk]

http://www.thewildbeast.co.uk/claws-mail/bugzilla/show_bug.cgi?id=3148

            Bug ID: 3148
           Summary: Logic error in claws_get_socket_name()
    Classification: Unclassified
           Product: Claws Mail
           Version: 3.9.3
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: minor
          Priority: P3
         Component: Other
          Assignee: users at lists.claws-mail.org
          Reporter: deweloper at wp.pl

Valgrind report for claws-mail-3.9.3-1.fc20.i686:

==00:00:00:05.490 2406== Conditional jump or move depends on uninitialised
value(s)
==00:00:00:05.490 2406==    at 0x80F9858: claws_get_socket_name (main.c:2147)
==00:00:00:05.490 2406==    by 0x80F99BE: prohibit_duplicate_launch
(main.c:2189)
==00:00:00:05.490 2406==    by 0x8080E2D: main (main.c:1001)

From
http://git.claws-mail.org/?p=claws.git;a=tree;f=src;h=982b9ceb382ffd6ca317acdce88d15c2993576e7;hb=HEAD
(line 2147 from report above is now line 2150):

2147                 if (stat(socket_dir, &st) < 0 && errno != ENOENT) {
2148                         g_print("Error stat'ing socket_dir %s: %s\n",
2149                                 socket_dir, strerror(errno));
2150                 } else if (S_ISSOCK(st.st_mode)) {

If stat() failed with errno=ENOENT, st.st_mode is being evaluated - what is
wrong since whole st structure is uninitialized due to stat() failure.

-- 
You are receiving this mail because:
You are the assignee for the bug.