[Users] [Bug 3138] New: pgpinline crashes on signature check if gppme fails to init

[noreply at thewildbeast.co.uk]

http://www.thewildbeast.co.uk/claws-mail/bugzilla/show_bug.cgi?id=3138

            Bug ID: 3138
           Summary: pgpinline crashes on signature check if gppme fails to
                    init
    Classification: Unclassified
           Product: Claws Mail
           Version: 3.9.3
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: minor
          Priority: P3
         Component: Plugins/Privacy
          Assignee: users at lists.claws-mail.org
          Reporter: timo.teras at iki.fi

Core was generated by `claws-mail'.
Program terminated with signal 11, Segmentation fault.
#0  pgpinline_is_signed (mimeinfo=0x128b5ab0) at pgpinline.c:140
140        data->done_sigtest = TRUE;

(gdb) where
#0  pgpinline_is_signed (mimeinfo=0x128b5ab0) at pgpinline.c:140
#1  0x108b72e3 in privacy_mimeinfo_is_signed (
    mimeinfo=mimeinfo at entry=0x128b5ab0) at privacy.c:144
#2  0x107faf2e in msginfo_set_mime_flags (node=0x126c0a20, data=0x12566fc0)
    at folder.c:2869
#3  0x4fca3065 in g_node_children_foreach () from /usr/lib/libglib-2.0.so.0
#4  0x10803203 in folder_item_fetch_msg (item=0x1208af90, num=130685)
    at folder.c:2909
#5  0x108c01a3 in procmsg_get_message_file_path (
    msginfo=msginfo at entry=0x12566fc0) at procmsg.c:412
#6  0x10849931 in messageview_show (messageview=messageview at entry=0x11fd8870, 
    msginfo=msginfo at entry=0x12566fc0, all_headers=all_headers at entry=0)
    at messageview.c:1322
#7  0x108dd315 in summary_display_msg_full (
    summaryview=summaryview at entry=0x11f9ad40, row=0x126eac30, 
    new_window=new_window at entry=0, all_headers=all_headers at entry=0)
    at summaryview.c:3609
#8  0x108dd505 in summary_display_msg (
    summaryview=summaryview at entry=0x11f9ad40, row=<optimized out>)
    at summaryview.c:3421
#9  0x108e50fe in summary_key_pressed (widget=0x11e254c8, event=0x120dd820, 
    summaryview=0x11f9ad40) at summaryview.c:6741
#10 0x501baae0 in ?? () from /usr/lib/libgtk-x11-2.0.so.0

(gdb) p data
$2 = (PrivacyDataPGP *) 0x0

Suggested patch:
--- src/plugins/pgpinline/pgpinline.c.orig
+++ src/plugins/pgpinline/pgpinline.c
@@ -137,8 +137,10 @@
         data = pgpinline_new_privacydata();
         mimeinfo->privacy = (PrivacyData *) data;
     }
-    data->done_sigtest = TRUE;
-    data->is_signed = TRUE;
+    if (data != NULL) {
+        data->done_sigtest = TRUE;
+        data->is_signed = TRUE;
+    }

     return TRUE;
 }

-- 
You are receiving this mail because:
You are the assignee for the bug.