[Users] [Bug 2252] [API extension request] API for external password storage (keyring) plugin support

[noreply at thewildbeast.co.uk]

http://www.thewildbeast.co.uk/claws-mail/bugzilla/show_bug.cgi?id=2252

--- Comment #7 from Colin Leroy <colin at colino.net> ---
Hi Michal,

Thanks for the patches! I applied the first one. Concerning the second, here
are a few points:

+    /* all have to be set */
+    g_assert(user);

can you replace all the g_assert() calls with "cm_return_val_if_fail(user !=
NULL, FALSE)"? 

We prefer the sanity checks to fail without crashing; also cm_return functions
print out backtraces, which help us get good bugreports :)

OK, that was a unique point. Rest look great ! :)

-- 
You are receiving this mail because:
You are the assignee for the bug.