[Users] [Bug 2927] Optional case insensitivity for the attach-warner-plugin

[noreply at thewildbeast.co.uk]

http://www.thewildbeast.co.uk/claws-mail/bugzilla/show_bug.cgi?id=2927

--- Comment #1 from Ricardo Mones <mones at users.sourceforge.net> ---

Thanks for the patch! Looks good!

> Add a checkbox in the attach-warner-plugin preferences in order to
> make patterns case insensitive. This is the new default behavior.

Well, that breaks the meaning of existing configurations so I've
kept this as case sensitive. Also reordered a bit the position of
the checkbox.

> Side effect on the address-keeper-plugin, which uses the same 
> function in matcher.c
>
> address-keeper-plugin now also defaults to case insensitive (seams
> to be the best option for email addresses). I'm not sure it makes 
> much sense to make this optional through the preferences dialog...

Probably not, as a at b.c is same address as A at B.C, cannot figure out
why one would like to keep both as if they were different.

> Another slight side-effect in matcher.c :
>
> The matcherlist_new_from_lines function had different behaviors
> for unix-like and non-unix-like systems in terms of case sensitivity.
>
> Now, the behavior is coherent and set by an additional boolean parameter.

Nice.

> I checked if this function was in use in the code base with a find/grep
> combination, but only found the two aforementioned plugins.

Yep, was common code on both, no other uses it, yet :)

> Certainly needs further testing, although there are only small changes
> in the code.

Tested and works well, committing.

-- 
You are receiving this mail because:
You are the assignee for the bug.