[Users] [Bug 2882] [Fancy Viewer] Reverse preference for external content

[noreply at thewildbeast.co.uk]

http://www.thewildbeast.co.uk/claws-mail/bugzilla/show_bug.cgi?id=2882

Colin Leroy <colin at colino.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #1238|0                           |1
        is obsolete|                            |

--- Comment #5 from Colin Leroy <colin at colino.net> ---
Created attachment 1241
  -->
http://www.thewildbeast.co.uk/claws-mail/bugzilla/attachment.cgi?id=1241&action=edit
Patch that makes link handling in Fancy saner IMO

Hi,

After looking at it, I'd go much further than that with Block external content:
I'd basically remove it with "Enable inner navigation".

Right now, "Block external content" does:
- prevent clicking on links
- prevent right-click/Download link
- prevent right-click/Save image

It does NOT:
- prevent auto download of images (that's controlled by Auto-load images)
- prevent auto download of javascript (that's controlled by Enable scripts)
- prevent auto download of applets (that's controlled by Enable java)
- prevent auto download of css (that can't be disabled)

So, in my not-so-humble opinion it is only an annoyance to the user, preventing
him from performing actions he asks for unless he unchecks Block external
content.

I have a patch that I'm going to attach that does the following:
- Remove "Block external content" and add "Enable inner navigation".
- Change the viewer's override menu so that it uses check menu items defaulting 
  to the normal preferences
- Have right-click menu items always active and always triggering events, like 
  "Save image", "Download link", "Open in browser" and "Open in viewer", NOT 
  depending on the preferences
- Have a click on a link perform the default action, that is either "Do 
  nothing" (no "Enable inner navigation" and no "Open links in browser"), or 
  "Open link in viewer" ("Enable inner navigation"), or "Open links in 
  browser").

That, I think, would do the right thing in all cases. The only minor annoyance
is that if "Enable inner navigation" is disabled, after navigating to another
page using right-click/"Open in viewer", one can't right-click/Back or
right-click/Forward.

Salvatore, what's your opinion with that? (hint: you should agree :))

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching someone on the CC list of the bug.