[Users] [Bug 2173] Message subject encoding is assumed ISO 8859-1 instead of using charset in Content-Type header

[noreply at thewildbeast.co.uk]

http://www.thewildbeast.co.uk/claws-mail/bugzilla/show_bug.cgi?id=2173





--- Comment #8 from Andrey Gursky  2012-09-16 23:08:17 ---
If the received message contains no properly formatted subject field, that
misses the used encoding, it is essential to guess one. And the best suggestion
for guess is try to look in one in Content-Type. If one was found, it is
obviously to assume that the same has been used also for the subject. So this
one should be made default_encoding for all subsequent calls to
conv_unmime_header(..., const gchar   *default_encoding, ...). The argument is
just for this puprose and now is being ignored at all.

PLEASE, make use of it.

For example how this done in sylpheed:
procheader.c:
MsgInfo *procheader_parse_stream(FILE *fp, MsgFlags flags, gboolean full)
...
    gchar *charset = NULL;
...
        case H_SUBJECT:
            if (msginfo->subject) break;
            subject = g_strdup(hp);
            break;
...
        case H_CONTENT_TYPE:
            if (!g_ascii_strncasecmp(hp, "multipart", 9)) {
                MSG_SET_TMP_FLAGS(msginfo->flags, MSG_MIME);
            } else if (!charset) {
                procmime_scan_content_type_str
                    (hp, NULL, &charset, NULL, NULL);
            }
            break;
...
    if (subject) {
        msginfo->subject = conv_unmime_header(subject, charset);
        subst_control(msginfo->subject, ' ');
        g_free(subject);
    }
...
----------------

Thanks,
Andrey

-- 
Configure bugmail: http://www.thewildbeast.co.uk/claws-mail/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.