[Users] [Bug 1961] Patches for a couple of clang warnings

noreply at thewildbeast.co.uk noreply at thewildbeast.co.uk
Wed Sep 12 11:29:21 CEST 2012


Colin Leroy <colin at colino.net> changed:

           What    |Removed                     |Added
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #8 from Colin Leroy  2012-09-12 11:29:20 ---

Better late than never... Patches applied. A few comments about

Subject: [PATCH 02/10] In procmsg_list_sort_by_account(), give nothing_to_sort
the chance to be FALSE when it's checked. XXX: This is a guess.
Initially applied but I reverted it, I don't remember what this is supposed to
do :)

Subject: [PATCH 03/10] Not sure about this one, but otherwise w_hbox would have
no purpose.
w_hbox had no purpose :)

Subject: [PATCH 07/10] Remove interim variable tags. Maybe tmp should be
renamed to tags.
In fact tags was there to keep the pointer at the start of the list in order to
free it. This was a leak.

Subject: [PATCH 09/10] Remove write-only variable is_group.
Kept it, I find it makes the if logic more clear

Thanks for your patches !

Configure bugmail: http://www.thewildbeast.co.uk/claws-mail/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the Users mailing list