[Users] [PATCH 2/3] Do not allow search cost to explode in case of bad message parsing in textview_make_clickable_parts_later();

Colin Leroy colin at colino.net
Mon Oct 29 14:44:58 CET 2012


On Thu, 25 Oct 2012 16:42:30 +0200, Igor Mammedov <imammedo at redhat.com>
wrote:

Hi,

> I've doubts about this patch written in cover letter, that seems
> haven't made to list:
> >> I'm not sure if [2/3] patch is totally correct, because of I've
> >> dropped "tmp < scanpos" so changing ordering from sorted by
> >> position to sorted by pattern. Hope someone knows better how it
> >> should work and can fix next block if necessary.  
> So there might be another issues caused by change.

Indeed, that caused other issues (for example with unsubscribe links
like http://abcd.com/?email=example@example.com). We reverted patch 2/3
(and 3/3 which applied on top of 2/3) in case no one finds time to fix
them before the next release.

Thanks,
-- 
Colin



More information about the Users mailing list