[Users] [Bug 2577] Focus rectangle on folder list and message list headings doesn't get properly ...

[Michael Shell]

On Thu, 8 Mar 2012 11:13:12 +0100
Andreas Rönnquist <mailinglists at gusnan.se> wrote:

> If marking lines using Ctrl+ mouse leftclicking, messages are marked
> as they should be, but when unmarking, using Ctrl and mouseclicking
> again, lines are left in the view


OK, it turns out this is caused by yet another issue.

Changing line 939 of src/gtk/gtkcmctree.c from:


gtk_widget_get_can_focus (widget) && gtk_widget_has_focus (widget))


to:


gtk_widget_get_can_focus (widget) && gtk_widget_has_focus (widget) && state == GTK_STATE_SELECTED)


is a workaround. The attached patch does this and is needed in
addition to, and to be applied after, the previous patch I supplied.

The problem is caused by the fact that apparently
gtk_widget_has_focus() remains true when using ctrl-click
to deselect a message and thus the focus lines/rectangle is still
drawn.

The above fix confines focus rectangle/line drawing to selected
messages only.

Perhaps there is a need to review what is meant to be indicated
by the "focus rectangle". To me, it should be used to indicate
which message is actually being displayed below and thus it could
happen even in deselected messages, but never on more than one.
However, properly tracking that would be require different logic and
well as the need to "erase" previous focus rectangle instances after
the current one moves. As it is, the focus rectangle is just selection
decoration.


Anyway, can you still find a way to break it after this latest
fix Andreas?


  Cheers,

  Mike Shell





-------------- next part --------------
A non-text attachment was scrubbed...
Name: claws_bug_2577_fix2.patch
Type: text/x-patch
Size: 536 bytes
Desc: not available
URL: <http://lists.claws-mail.org/pipermail/users/attachments/20120310/cb85f338/attachment.bin>