[Users] [Bug 2574] New: Statement might be overflowing a buffer in strncat.

[noreply at thewildbeast.co.uk]

http://www.thewildbeast.co.uk/claws-mail/bugzilla/show_bug.cgi?id=2574

           Summary: Statement might be overflowing a buffer in strncat.
           Product: Claws Mail
           Version: 3.8.0
          Platform: PC
        OS/Version: Linux
            Status: NEW
          Severity: major
          Priority: P3
         Component: UI/Address Book
        AssignedTo: users at lists.claws-mail.org
        ReportedBy: malcolmlewis at opensuse.org


Created an attachment (id=1057)
 --> (http://www.thewildbeast.co.uk/claws-mail/bugzilla/attachment.cgi?id=1057)
claws-mail-fix-bufferoverflowstrncat.patch

Hi
When building claws-mail 3.8.0 on the Open Build Service
(https://build.opensuse.org/) I receive the following errors and am
unable to finish the building;

======================================================================
I: Statement might be overflowing a buffer in strncat. Common mistake:
   BAD: strncat(buffer,charptr,sizeof(buffer)) is wrong, it takes the
   left over size as 3rd argument
   GOOD: strncat(buffer,charptr,sizeof(buffer)-strlen(buffer)-1)
E: claws-mail bufferoverflowstrncat addrbook.c:1849:10
E: claws-mail bufferoverflowstrncat exportldif.c:234:12
E: claws-mail bufferoverflowstrncat exportldif.c:238:13
E: claws-mail bufferoverflowstrncat exportldif.c:243:13
E: claws-mail bufferoverflowstrncat exportldif.c:250:14
======================================================================

I have attached a patch which fixes the build issue.

-- 
Configure bugmail: http://www.thewildbeast.co.uk/claws-mail/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.