[Users] Question regarding forward of HTML e-mails

Colin Leroy colin at colino.net
Sun Aug 12 18:18:54 CEST 2012


On 12 August 2012 at 17h40, Michael Gmelin wrote:

Hi, 

> I checked the fix in CVS (3.8.1cvs30) and I think there is a typo in
> there - in line 1472 of messageview.c it says:
> 
> mimeinfo->disposition == DISPOSITIONTYPE_ATTACHMENT

Oops. Fixed in CVS, thanks.

> Also, after testing the change I realized, that this is still showing
> the HTML part of multipart/mixed (whereas the setting says it will
> only show multipart/alternative).
> 
> So I would suggest to also check if alt_parent->subtype ==
> "alternative". (The changes after line 1495 are fine, the comparison
> operator is ok and since it is only executed in the context of a
> multipart/alternative header anyway).

Yeah, I wonder if we wouldn't break other cases that I can't think of
right now. I remember adding these for a reason, but don't remember
which one... I'll investigate further...
-- 
Colin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 190 bytes
Desc: not available
URL: <http://lists.claws-mail.org/pipermail/users/attachments/20120812/860d1ff1/attachment.sig>


More information about the Users mailing list