[Commits] [SCM] claws branch, master, updated. 4.3.1-52-g9ec1e07f5

[wwp]

Hello Michael,


On Sat, 22 Mar 2025 08:56:21 +0000 (UTC) miras at claws-mail.org wrote:

snip]
> commit 9ec1e07f5ab14fe975e4ff389fcf43ce714274da
> Author: Michael Rasmussen <mir at datanom.net>
> Date:   Sat Mar 22 09:56:13 2025 +0100
> 
>     Fix CID 1645078: (RESOURCE_LEAK)
>     
>     Signed-off-by: Michael Rasmussen <mir at datanom.net>
> 
> diff --git a/src/plugins/rssyl/rssyl_update_feed.c b/src/plugins/rssyl/rssyl_update_feed.c
> index 91eba8dbc..eca2c970a 100644
> --- a/src/plugins/rssyl/rssyl_update_feed.c
> +++ b/src/plugins/rssyl/rssyl_update_feed.c
> @@ -268,10 +268,12 @@ gboolean rssyl_update_feed(RFolderItem *ritem, RSSylVerboseFlags verbose)
>  	MainWindow *mainwin = mainwindow_get_mainwindow();
>  	gchar *msg = NULL;
>  	gboolean success = FALSE;
> -	gchar *user_agent = rssyl_get_user_agent(ritem);
> +	gchar *user_agent = NULL;
>  
>  	g_return_val_if_fail(ritem != NULL, FALSE);
>  	g_return_val_if_fail(ritem->url != NULL, FALSE);
> +	
> +	user_agent = rssyl_get_user_agent(ritem);
>  
>  	debug_print("RSSyl: starting to update '%s' (%s)\n",
>  			ritem->item.name, ritem->url);

Thanks for this enormous one :-) (by chance it should never happen -
saying should and by chance is a bit scary, I admit :-D). I've been
punished for adding the g_return_val_if_fail's without checking :-/.


Regards,

-- 
wwp
https://useplaintext.email/