[Commits] [SCM] claws branch, master, updated. 4.1.1-113-g7dbde9581

mones at claws-mail.org mones at claws-mail.org
Fri Nov 10 17:34:39 UTC 2023


The branch, master has been updated
       via  7dbde958181a993c468f33899b5474af3cf50a36 (commit)
       via  7ac7d0b4818ff675d05b5f5df877bb652fcd7faa (commit)
      from  d0dbd94b829a2c8317738ecacc1bbabf61daae94 (commit)

Summary of changes:
 src/mimeview.c    | 8 ++++----
 src/summaryview.c | 4 ++--
 2 files changed, 6 insertions(+), 6 deletions(-)


- Log -----------------------------------------------------------------
commit 7dbde958181a993c468f33899b5474af3cf50a36
Author: Ricardo Mones <ricardo at mones.org>
Date:   Fri Nov 10 18:33:19 2023 +0100

    More parentheses for yet another warning
    
    summaryview.c:3986:66: warning: suggest parentheses around ‘&&’ within ‘||’

diff --git a/src/summaryview.c b/src/summaryview.c
index 2ea4d741b..81beb2a41 100644
--- a/src/summaryview.c
+++ b/src/summaryview.c
@@ -3982,9 +3982,9 @@ static void summary_set_row_marks(SummaryView *summaryview, GtkCMCTreeNode *row)
 					"");
 	}
 
-	if (((prefs_common.bold_unread && MSG_IS_UNREAD(flags)) ||
+	if ((((prefs_common.bold_unread && MSG_IS_UNREAD(flags)) ||
 	     (prefs_common.bold_marked && MSG_IS_MARKED(flags))) &&
-	    !MSG_IS_IGNORE_THREAD(flags) ||
+	    !MSG_IS_IGNORE_THREAD(flags)) ||
 	    (!GTK_CMCTREE_ROW(row)->expanded &&
 	      GTK_CMCTREE_ROW(row)->children &&
 	      summary_have_unread_children(summaryview, row)))

commit 7ac7d0b4818ff675d05b5f5df877bb652fcd7faa
Author: Ricardo Mones <ricardo at mones.org>
Date:   Fri Nov 10 18:33:09 2023 +0100

    Add parentheses to fix warning
    
    mimeview.c:1946:39: warning: suggest parentheses around ‘&&’ within ‘||’

diff --git a/src/mimeview.c b/src/mimeview.c
index 80402611c..5b5f6e6fc 100644
--- a/src/mimeview.c
+++ b/src/mimeview.c
@@ -1943,14 +1943,14 @@ static void mimeview_save_all(MimeView *mimeview, gboolean attachments_only)
 	}
 
 	while (partinfo != NULL) {
-		if (!attachments_only &&
+		if ((!attachments_only &&
 		    (partinfo->type != MIMETYPE_MESSAGE &&
 		     partinfo->type != MIMETYPE_MULTIPART &&
 		     (partinfo->disposition != DISPOSITIONTYPE_INLINE ||
-		      get_real_part_name(partinfo) != NULL)) ||
-		     attachments_only &&
+		      get_real_part_name(partinfo) != NULL))) ||
+		    (attachments_only &&
 		     (partinfo->disposition == DISPOSITIONTYPE_ATTACHMENT &&
-		      get_real_part_name(partinfo) != NULL)) {
+		      get_real_part_name(partinfo) != NULL))) {
 			gchar *filename = mimeview_get_filename_for_part(
 				partinfo, dirname, number++);
 

-----------------------------------------------------------------------


hooks/post-receive
-- 
Claws Mail


More information about the Commits mailing list