[Commits] [SCM] claws branch, gtk3, updated. 4.0.0-188-ge90e11cad

[Jonathan Boeing]

On Wed, 15 Sep 2021 10:35:32 +0200
wwp <wwp at claws-mail.org> wrote:

> Hello Jonathan,
> 
> 
> On Wed, 15 Sep 2021 00:36:05 -0700 Jonathan Boeing
> <jonathan at claws-mail.org> wrote:
> 
> > On Wed, 15 Sep 2021 08:38:13 +0200
> > wwp <wwp at claws-mail.org> wrote:
> >   
> > > I'm not 100% sure but I'm afraid that with GTK3 we have to take
> > > both scrolling methods into account: the smooth one (w/ deltas)
> > > and the plain basic up/down one. Following the system where I
> > > tested it, I had one or the other working, when I was working on
> > > d4e2645d82e74b9a24c34ec2edb2430529ef4354. See
> > > textview_scrolled().    
> > 
> > Well, handling both the smooth and basic cases was my intent at
> > least. Did I break the non-smooth scrolling case?
> > 
> > In my testing I only ever saw GDK_SCROLL_SMOOTH events in that
> > function. Even with smooth scrolling seemingly disabled everywhere
> > all the events were smooth scrolls.
> > 
> > Anyways, I was trying to integrate the smooth case into the existing
> > if/else clauses rather than add an additional 'else if' to avoid
> > duplicating the rest of the logic.  The lines:
> > 
> > if ((delta_y < 0.0 || event->direction == GDK_SCROLL_UP) &&
> > 
> > and
> > 
> > else if ((delta_y > 0.0 || event->direction == GDK_SCROLL_DOWN) &&
> > 
> > should handle either case, no?  
> 
> Definitely yes, I've just misread the diff, w/ my blurry morning eyes,
> sorry!
> 
> 
> Regards,
> 

No worries.

Regards,

Jonathan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://lists.claws-mail.org/pipermail/commits/attachments/20210915/017912db/attachment.sig>