[Commits] [SCM] claws branch, master, updated. 3.18.0-259-gbac407684

wwp at claws-mail.org wwp at claws-mail.org
Wed Oct 6 09:50:40 CEST 2021


The branch, master has been updated
       via  bac407684aa94e3d41464ceb0596f41efc0b8440 (commit)
      from  17bc6d54f0b984de39badbccb4024bbedcdbfce8 (commit)

Summary of changes:
 src/edittags.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)


- Log -----------------------------------------------------------------
commit bac407684aa94e3d41464ceb0596f41efc0b8440
Author: wwp <subscript at free.fr>
Date:   Wed Oct 6 09:49:27 2021 +0200

    Fix CID 1492202: dereference before null check (we usually test if gtk_editable_get_chars
    returns NULL, but it should not).

diff --git a/src/edittags.c b/src/edittags.c
index 42b5af88a..4c9f0510d 100644
--- a/src/edittags.c
+++ b/src/edittags.c
@@ -434,8 +434,10 @@ static gboolean find_tag_in_store(GtkTreeModel *model,
 static void tags_window_add_tag(void)
 {
 	gchar *new_tag = gtk_editable_get_chars(GTK_EDITABLE(tagswindow.add_entry), 0, -1);
+	if (!new_tag)
+		return;
 	g_strstrip(new_tag);
-	if (new_tag && *new_tag) {
+	if (*new_tag) {
 		gint id;
 		FindTagInStore fis;
 		if (!(IS_NOT_RESERVED_TAG(new_tag))) {

-----------------------------------------------------------------------


hooks/post-receive
-- 
Claws Mail


More information about the Commits mailing list