[Commits] [SCM] claws branch, master, updated. 3.17.3-193-g4da0c05

Colin colin at claws-mail.org
Sun Jul 7 18:45:14 CEST 2019


The branch, master has been updated
       via  4da0c05d2715f855ca78c98b2187688919dbfc0c (commit)
      from  c577fa6a1d5764e7086214d622a003b3716cc44a (commit)

Summary of changes:
 src/procmime.c |    7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)


- Log -----------------------------------------------------------------
commit 4da0c05d2715f855ca78c98b2187688919dbfc0c
Author: Colin Leroy <colin at colino.net>
Date:   Sun Jul 7 18:44:54 2019 +0200

    Fix dereferencing of potentially NULL *error

diff --git a/src/procmime.c b/src/procmime.c
index cfcc642..cc641c6 100644
--- a/src/procmime.c
+++ b/src/procmime.c
@@ -2750,16 +2750,13 @@ GdkPixbuf *procmime_get_part_as_pixbuf(MimeInfo *mimeinfo, GError **error)
 		*error = NULL;
 
 	stream = procmime_get_part_as_inputstream(mimeinfo);
-	if (stream == NULL) {
-		if (*error)
-			*error = g_error_new_literal(G_FILE_ERROR, -1, _("Could not decode part"));
+	if (stream == NULL)
 		return NULL;
-	}
 
 	pixbuf = gdk_pixbuf_new_from_stream(stream, NULL, error);
 	g_object_unref(stream);
 
-	if (*error != NULL)
+	if (error && *error != NULL)
 		return NULL;
 
 	return pixbuf;

-----------------------------------------------------------------------


hooks/post-receive
-- 
Claws Mail


More information about the Commits mailing list