[Commits] [SCM] claws branch, master, updated. 3.17.0-46-g1c069e3

[Ricardo Mones]

On Thu,  6 Sep 2018 22:14:26 +0200 (CEST)
ticho at claws-mail.org wrote:

> +		debug_print("Could not find a NULL byte in the decrypted
> password.\n");
> +		valid_utf8 = FALSE;
> +	} else {
> +		/* There is a NULL byte, we can rely on strlen() returning

I find this “NULL byte” peculiar: NULL, even being 0 most of the time, is a
pointer and probably never byte sized ;-) maybe you wanted to mean NUL?

> +	if (!valid_utf8)
> +		debug_print("Decrypted password is not a valid UTF-8
> string!\n");
> +	cm_return_val_if_fail(valid_utf8, NULL);

What about a g_warning() instead to make these failures readily available in
console?

regards,
-- 
  Ricardo Mones 
  ~
  The world will end in 5 minutes. Please log out.            Unknown