[Commits] [SCM] claws branch, master, updated. 3.17.0-81-g618839a

[Andrej Kacian]

On Fri, 5 Oct 2018 23:47:39 +0200
Michael Rasmussen wrote:

> Hi Colin,
> 
> Patch below breaks building claws since src/common is build before src
> linking of src/common fails since safe_fclose.c at build time of
> src/common is not build yet. I would suggest that safe_fclose.c is
> moved to src/commons instead and then all references in src for
> safe_fclose adjusted accordingly.

I think a reasonably clean solution would be to move the file-related
functions out of utils.c into something like file-utils.c, and moving
safe_fclose() there as well.

Since Colin's patch also added the new -I flag to src/common
AM_CPPFLAGS, the new file can be in that directory.

By the way, your suggestion of just moving the file would not suffice,
we'd also have to add safe_fsync.o to LDADD of the individual test
programs in their Makefile.am, otherwise safe_fsync would still be an
unknown symbol when linking the programs.

With the functions moved outside of utils.c, the test programs won't
care about not knowing about safe_fclose anymore.

Regards,
-- 
Andrej
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://lists.claws-mail.org/pipermail/commits/attachments/20181006/40cedcde/attachment.sig>