[Commits] [SCM] claws branch, gtk3, updated. 3.16.0-102-gb423102

[mones at claws-mail.org]

The branch, gtk3 has been updated
       via  b423102b353f8cb97fd748c4d155022c29d64842 (commit)
      from  12f611aab4340d5d33dd0f13a2af5bd4e65f5908 (commit)

Summary of changes:
 src/mainwindow.c  |    2 +-
 src/summaryview.c |   10 ----------
 src/summaryview.h |    1 -
 3 files changed, 1 insertion(+), 12 deletions(-)


- Log -----------------------------------------------------------------
commit b423102b353f8cb97fd748c4d155022c29d64842
Author: Paul <paul at claws-mail.org>
Date:   Sun Feb 25 13:18:40 2018 +0000

    fix bug 3973, ''select all' in summaryview does not automatically focus the summaryview'
    
    The problem is apparent when 'default selection on entering a folder' is
    set to 'none' and the first user action on entering the folder is
    'select all'. This visually selected all the messages but summaryview
    did not have the focus, so any actions performed on that list would
    fail.
    
    Removed summary_select_all(), which didn't quite do as advertised and
    instead use gtk_cmclist_select_all() which selects and focuses.

diff --git a/src/mainwindow.c b/src/mainwindow.c
index fc7b2f9..fb0dd71 100644
--- a/src/mainwindow.c
+++ b/src/mainwindow.c
@@ -4985,7 +4985,7 @@ static void allsel_cb(GtkAction *action, gpointer data)
 		 (gtk_widget_has_focus(msgview->mimeview->textview->text)))
 		messageview_select_all(mainwin->messageview);
 	else
-		summary_select_all(mainwin->summaryview);
+		gtk_cmclist_select_all(GTK_CMCLIST(mainwin->summaryview->ctree));
 }
 
 static void select_thread_cb(GtkAction *action, gpointer data)
diff --git a/src/summaryview.c b/src/summaryview.c
index 60938ef..257e850 100644
--- a/src/summaryview.c
+++ b/src/summaryview.c
@@ -4817,16 +4817,6 @@ void summary_add_address(SummaryView *summaryview)
 	avatars_avatarrender_free(avatarr);
 }
 
-void summary_select_all(SummaryView *summaryview)
-{
-	if (!summaryview->folder_item) return;
-
-	summary_lock(summaryview);
-	gtk_cmclist_select_all(GTK_CMCLIST(summaryview->ctree));
-	summary_unlock(summaryview);
-	summary_status_show(summaryview);
-}
-
 void summary_unselect_all(SummaryView *summaryview)
 {
 	summary_lock(summaryview);
diff --git a/src/summaryview.h b/src/summaryview.h
index 77ac05b..9d1d943 100644
--- a/src/summaryview.h
+++ b/src/summaryview.h
@@ -287,7 +287,6 @@ void summary_watch_thread	  (SummaryView 		*summaryview);
 void summary_unwatch_thread	  (SummaryView 		*summaryview);
 
 void summary_add_address	  (SummaryView		*summaryview);
-void summary_select_all		  (SummaryView		*summaryview);
 void summary_unselect_all	  (SummaryView		*summaryview);
 void summary_select_thread	  (SummaryView		*summaryview,
 				   gboolean		 delete_thread,

-----------------------------------------------------------------------


hooks/post-receive
-- 
Claws Mail