[Commits] [SCM] claws branch, master, updated. 3.14.1-118-gde7bb00

wwp at claws-mail.org wwp at claws-mail.org
Wed Jan 11 16:10:18 CET 2017


The branch, master has been updated
       via  de7bb00b0c877c5895341c28e01ae6408df2a06c (commit)
      from  f986aa1d86442c48afd6cb89f1fca2d5c31de20f (commit)

Summary of changes:
 src/plugins/clamd/libclamd/clamd-plugin.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)


- Log -----------------------------------------------------------------
commit de7bb00b0c877c5895341c28e01ae6408df2a06c
Author: wwp <wwp at free.fr>
Date:   Wed Jan 11 16:09:08 2017 +0100

    Quit function if no connection instead of assigning variable that
    will be overwriten right after.
    Fixes Coverity CID #1372370.

diff --git a/src/plugins/clamd/libclamd/clamd-plugin.c b/src/plugins/clamd/libclamd/clamd-plugin.c
index a45860a..8152d1d 100644
--- a/src/plugins/clamd/libclamd/clamd-plugin.c
+++ b/src/plugins/clamd/libclamd/clamd-plugin.c
@@ -513,7 +513,7 @@ Clamd_Stat clamd_verify_email(const gchar* path, response* result) {
 	}
 	sock = create_socket();
 	if (sock < 0) {
-		debug_print("no connection\n");
+		debug_print("no connection (socket create)\n");
 		return NO_CONNECTION;
 	}
 	memset(buf, '\0', sizeof(buf));
@@ -535,8 +535,8 @@ Clamd_Stat clamd_verify_email(const gchar* path, response* result) {
 		command = g_strconcat(scan, " ", path, "\n", NULL);
 		debug_print("command: %s\n", command);
 		if (write(sock, command, strlen(command)) == -1) {
-			debug_print("no connection\n");
-			stat = NO_CONNECTION;
+			debug_print("no connection (socket write)\n");
+			return NO_CONNECTION;
 		}
 		g_free(command);
 		memset(buf, '\0', sizeof(buf));

-----------------------------------------------------------------------


hooks/post-receive
-- 
Claws Mail


More information about the Commits mailing list