[Commits] [SCM] claws branch, master, updated. 3.13.2-92-g57e0b0d

Andrej Kacian andrej at kacian.sk
Mon Mar 28 00:22:42 CEST 2016


On Mon, 28 Mar 2016 00:00:58 +0200 (CEST)
colin at claws-mail.org (Colin) wrote:

> - Log -----------------------------------------------------------------
> commit 57e0b0d5d8b901d82155af0a313ba7ab94b52173
> Merge: bfd8acb b2654a1
> Author: Colin Leroy <colin at colino.net>
> Date:   Mon Mar 28 00:00:41 2016 +0200
> 
>     Merge branch 'master' of ssh://git.claws-mail.org/home/git/claws
> 
> 
> commit bfd8acbc1190673497931d5ccbcbc736ceb87905
> Author: Colin Leroy <colin at colino.net>
> Date:   Thu Mar 3 21:14:59 2016 +0100
> 
>     Fix unitialised access
> 
> diff --git a/src/prefs_gtk.c b/src/prefs_gtk.c
> index 2fce2f4..ccab0a3 100644
> --- a/src/prefs_gtk.c
> +++ b/src/prefs_gtk.c
> @@ -319,7 +319,7 @@ void prefs_write_config(PrefParam *param, const gchar *label,
>  gint prefs_write_param(PrefParam *param, FILE *fp)
>  {
>  	gint i;
> -	gchar buf[PREFSBUFSIZE];
> +	gchar buf[PREFSBUFSIZE] = "";
>  
>  	for (i = 0; param[i].name != NULL; i++) {
>  		switch (param[i].type) {

Perhaps setting it to "\0" would be better, as that's what's being
checked for at the end anyway.

Also, padding our commit count with the bogus "Merge branch" commits,
are we? :)

Regards,
-- 
Andrej


More information about the Commits mailing list