[Commits] [SCM] claws branch, master, updated. 3.13.2-15-geb130cb

ticho at claws-mail.org ticho at claws-mail.org
Fri Feb 5 10:46:11 CET 2016


The branch, master has been updated
       via  eb130cbe507a9877d59d444065140960a828af67 (commit)
      from  ad9ddd799eff250b2f7a7a8752a9ffed282c2f98 (commit)

Summary of changes:
 src/imap.c |    2 --
 1 file changed, 2 deletions(-)


- Log -----------------------------------------------------------------
commit eb130cbe507a9877d59d444065140960a828af67
Author: Andrej Kacian <ticho at claws-mail.org>
Date:   Fri Feb 5 10:43:15 2016 +0100

    Fix a null pointer dereference introduced by 54adfb4.
    
    acc_pass is pointing to same address as pass, and we are inside
    an if block that includes "!pass" condition, so trying to zero
    and free acc_pass is a wrong thing to do.

diff --git a/src/imap.c b/src/imap.c
index 8ccf871..df0fbc5 100644
--- a/src/imap.c
+++ b/src/imap.c
@@ -1274,8 +1274,6 @@ try_again:
 							    account->userid,
 							    &(account->session_passwd));
 		if (!tmp_pass) {
-			memset(acc_pass, 0, strlen(acc_pass));
-			g_free(acc_pass);
 			return MAILIMAP_NO_ERROR;
 		}
 		Xstrdup_a(pass, tmp_pass, {g_free(tmp_pass); return MAILIMAP_NO_ERROR;});

-----------------------------------------------------------------------


hooks/post-receive
-- 
Claws Mail


More information about the Commits mailing list